Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clarification text to controlled input example #909

Conversation

omglolbrbb4n
Copy link

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 56c88ee

https://deploy-preview-909--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@kevinli-webbertech
Copy link

hey there, I had a PR recently, and it does not pass the check, you saw you had this one merged, so just curious about it, is anyone is responsible in looking and retriger these failed ones?

Copy link

@ndobryanskyy ndobryanskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better as follows:
"### Remark:
There is currently a known issue with typing in the middle of the input. You'll notice, that cursor jumps to the end of the input. Currently there is no recommended workaround for this behavior."

Feel free to correct this spelling also.
And thumbs up for code pen.
If you like the change we could also include some links with possible solutions for the issue too. Haven't done the good research yet.

@BartoszKlonowski
Copy link
Collaborator

Hello @omglolbrbb4n! Let me close this PR as this addresses the issue that is already closed and the PR is already pretty much outdated.
Feel free to create new PR for other open issues. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants