Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cn): translate content/docs/create-a-new-react-app.md into Chinese #104

Merged
merged 4 commits into from Mar 18, 2019
Merged

docs(cn): translate content/docs/create-a-new-react-app.md into Chinese #104

merged 4 commits into from Mar 18, 2019

Conversation

seognil
Copy link
Contributor

@seognil seognil commented Feb 16, 2019

No description provided.

@seognil seognil mentioned this pull request Feb 16, 2019
Closed
@QC-L QC-L added the Pending Review 已翻译，待校对阶段 label Feb 17, 2019
ColinCLL
ColinCLL reviewed Feb 21, 2019
View reviewed changes
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
@QC-L QC-L requested a review from robertying March 13, 2019 10:03
@robertying robertying self-assigned this Mar 13, 2019
robertying
robertying requested changes Mar 14, 2019
View reviewed changes
Copy link
Collaborator

@robertying robertying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍！
个人认为没有大问题，就是需要注意一下中文之间没有空格。
可以赶紧修改，很快可以 merge。

content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
@robertying
Copy link
Collaborator

还有一个 conflict，记得顺带修复一下~

@QC-L QC-L added Pending Modify 已校对，待修改阶段 and removed Pending Review 已翻译，待校对阶段 labels Mar 14, 2019
@netlify
Copy link

netlify bot commented Mar 14, 2019 •
edited
Loading

Deploy preview for cn-reactjs ready!

Built with commit 78918a2

https://deploy-preview-104--cn-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 14, 2019 •
edited
Loading

Deploy preview for zh-hans-reactjs ready!

Built with commit 78918a2

https://deploy-preview-104--zh-hans-reactjs.netlify.com

seognil
seognil commented Mar 16, 2019
View reviewed changes
Copy link
Contributor Author

@seognil seognil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

content/docs/nav.yml Outdated Show resolved Hide resolved
robertying
robertying previously approved these changes Mar 16, 2019
View reviewed changes
QC-L
QC-L previously approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@QC-L QC-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他问题不大。
LGTM

@seognil seognil dismissed stale reviews from QC-L and robertying via 78918a2 March 18, 2019 07:32
QC-L
QC-L approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@QC-L QC-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QC-L QC-L merged commit e073afb into reactjs:master Mar 18, 2019
OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
@seognil @QC-L
docs(cn): translate content/docs/create-a-new-react-app.md into Chine…
9d76977 
…se (reactjs#104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinCLL ColinCLL ColinCLL left review comments

@QC-L QC-L QC-L approved these changes

@robertying robertying robertying left review comments

Assignees

@robertying robertying

Labels
Pending Modify 已校对，待修改阶段
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seognil @robertying @QC-L @ColinCLL