doc: translation render props #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cn-reactjs ready! Built with commit d05c25a |
Closed
lcxfs1991
requested changes
Feb 23, 2019
|
@chenshuai2144 有些需要调整哈 |
lcxfs1991
requested changes
Feb 23, 2019
|
Deploy preview for zh-hans-reactjs ready! Built with commit d05c25a |
lcxfs1991
requested changes
Feb 24, 2019
lcxfs1991
previously approved these changes
Feb 24, 2019
hijiangtao
requested changes
Feb 24, 2019
There was a problem hiding this comment.
原文还存在较多问题，建议 @QC-L 再添加一位 reviewer 进行审校。
- 「您」的称呼
- Google Translate 应该会默认略去 `` 符号，但翻译中需再添回
- 部分语句还有些不通畅
- 中英文空格问题
- 类似「复用」的词汇全文应保持一致
|
需要等等 最近有点忙 |
Co-Authored-By: LeoEatle <[email protected]>
谜之重复，我直接合了 Co-Authored-By: LeoEatle <[email protected]>
这种中英文空格问题我都直接合入 Co-Authored-By: LeoEatle <[email protected]>
Co-Authored-By: LeoEatle <[email protected]>
Co-Authored-By: LeoEatle <[email protected]>
Co-Authored-By: LeoEatle <[email protected]>
Co-Authored-By: LeoEatle <[email protected]>
|
QC-L 提出的修改大多数是中英文空格问题和格式问题，我都直接提交了。麻烦把 hijiangtao 提出的建议改一下，之后 @hijiangtao 看下修改没问题就能合入了。 刚才提交的时候应当用 batch 合并 commit 的，最后合并的时候注意要 squash and merge 。 |
OhIAmFine
pushed a commit
to OhIAmFine/zh-hans.reactjs.org
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translation render props