Release the incoming message on the client when the decoding failed

reactor · Aug 20, 2018 · 3373c66 · 3373c66
1 parent caa1adf
commit 3373c66
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/main/java/reactor/ipc/netty/http/client/HttpClientOperations.java b/src/main/java/reactor/ipc/netty/http/client/HttpClientOperations.java
@@ -547,6 +547,7 @@ protected void onInboundNext(ChannelHandlerContext ctx, Object msg) {
 			            .isFailure()) {
 				onInboundError(response.decoderResult()
 				                       .cause());
+				ReferenceCountUtil.release(msg);
 				return;
 			}
 			if (started) {
@@ -555,6 +556,7 @@ protected void onInboundNext(ChannelHandlerContext ctx, Object msg) {
 							response.headers()
 							        .toString());
 				}
+				ReferenceCountUtil.release(msg);
 				return;
 			}
 			started = true;
@@ -593,6 +595,7 @@ protected void onInboundNext(ChannelHandlerContext ctx, Object msg) {
 					log.debug(format(channel(), "HttpClientOperations received an incorrect end " +
 							"delimiter (previously used connection?)"));
 				}
+				ReferenceCountUtil.release(msg);
 				return;
 			}
 			if (log.isDebugEnabled()) {
@@ -619,6 +622,7 @@ protected void onInboundNext(ChannelHandlerContext ctx, Object msg) {
 								"(previously used connection?)"),
 						msg);
 			}
+			ReferenceCountUtil.release(msg);
 			return;
 		}
 		super.onInboundNext(ctx, msg);