Skip to content

Commit

Permalink
fix #783 If a handler is added with Connection#addHandler*, events pr…
Browse files Browse the repository at this point in the history
…ior channel active state are not available
  • Loading branch information
violetagg committed Jul 26, 2019
1 parent a9a09fe commit 6a98e38
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/main/java/reactor/netty/Connection.java
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ default <T extends Connection> T as(Class<T> clazz) {
* <p>
* If effectively added, the handler will be safely removed when the channel is made
* inactive (pool release).
* As the Connection object is available once the channel is in active state, events prior this state
* will not be available (i.e. {@code channelRegistered}, {@code initChannel}, {@code channelActive}, etc.)
*
* @param handler handler instance
*
Expand All @@ -94,6 +96,8 @@ default Connection addHandler(ChannelHandler handler){
* <p>
* If effectively added, the handler will be safely removed when the channel is made
* inactive (pool release).
* As the Connection object is available once the channel is in active state, events prior this state
* will not be available (i.e. {@code channelRegistered}, {@code initChannel}, {@code channelActive}, etc.)
*
* @param name handler name
* @param handler handler instance
Expand All @@ -119,6 +123,8 @@ default Connection addHandler(String name, ChannelHandler handler){
* <p>
* If effectively added, the handler will be safely removed when the channel is made
* inactive (pool release).
* As the Connection object is available once the channel is in active state, events prior this state
* will not be available (i.e. {@code channelRegistered}, {@code initChannel}, {@code channelActive}, etc.)
*
* @param handler handler instance
*
Expand All @@ -138,6 +144,8 @@ default Connection addHandlerLast(ChannelHandler handler){
* <p>
* If effectively added, the handler will be safely removed when the channel is made
* inactive (pool release).
* As the Connection object is available once the channel is in active state, events prior this state
* will not be available (i.e. {@code channelRegistered}, {@code initChannel}, {@code channelActive}, etc.)
*
* @param name handler name
* @param handler handler instance
Expand All @@ -158,6 +166,8 @@ default Connection addHandlerLast(String name, ChannelHandler handler){
* <p>
* If effectively added, the handler will be safely removed when the channel is made
* inactive (pool release).
* As the Connection object is available once the channel is in active state, events prior this state
* will not be available (i.e. {@code channelRegistered}, {@code initChannel}, {@code channelActive}, etc.)
*
* @param handler handler instance
*
Expand All @@ -176,6 +186,8 @@ default Connection addHandlerFirst(ChannelHandler handler){
* <p>
* If effectively added, the handler will be safely removed when the channel is made
* inactive (pool release).
* As the Connection object is available once the channel is in active state, events prior this state
* will not be available (i.e. {@code channelRegistered}, {@code initChannel}, {@code channelActive}, etc.)
*
* @param name handler name
* @param handler handler instance
Expand Down

0 comments on commit 6a98e38

Please sign in to comment.