Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to receive close status with WebSocketInbound #533

Closed
rstoyanchev opened this issue Nov 28, 2018 · 1 comment
Closed

No way to receive close status with WebSocketInbound #533

rstoyanchev opened this issue Nov 28, 2018 · 1 comment
Labels
type/enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Nov 28, 2018

WebsocketInbound provides Flux<WebSocketFrame> receiveFrames() which turns CloseWebSocketFrame into a completion signal, but a result there is no way to receive the close status and reason sent by the remote peer. This is asymmetric with WebSocketOutbound which does provide a way to send a close status and reason.

This same has been requested in SPR-17547 but in order to implement it there, we'd first need a way to get the close status through the Reactor Netty API.

@rstoyanchev
Copy link
Contributor Author

rstoyanchev commented Nov 28, 2018

One idea to consider, an extra method in WebSocketInbound:

/** 
  * Receive the close status code and reason if sent by the remote peer,
  * or empty if the connection completes otherwise.
  */
Mono<CloseStatus> receiveCloseStatus();

@violetagg violetagg added the type/enhancement A general enhancement label Nov 29, 2018
@violetagg violetagg added this to the 0.8.x Backlog milestone Nov 29, 2018
@smaldini smaldini modified the milestones: 0.8.x Backlog, 0.9.x Backlog Feb 7, 2019
OlegDokuka added a commit to OlegDokuka/reactor-netty that referenced this issue Aug 15, 2019
OlegDokuka added a commit to OlegDokuka/reactor-netty that referenced this issue Aug 15, 2019
@violetagg violetagg modified the milestones: 0.9.x Backlog, 0.9.0.M4 Aug 27, 2019
OlegDokuka added a commit to OlegDokuka/reactor-netty that referenced this issue Sep 1, 2019
OlegDokuka added a commit to OlegDokuka/reactor-netty that referenced this issue Sep 1, 2019
OlegDokuka added a commit to OlegDokuka/reactor-netty that referenced this issue Sep 1, 2019
violetagg pushed a commit that referenced this issue Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants