Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #553 Remove the deprecated HttpClient#chunkedTransfer #620

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

violetagg
Copy link
Member

By default Transfer-Encoding: chunked will be applied for those HTTP methods
for which a request body is expected. If the user wants to disable that setting
then the user can provide Content-Length via request headers and
thus Transfer-Encoding will be removed.

@violetagg violetagg added this to the 0.9.0.M1 milestone Feb 26, 2019
@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #620 into master will increase coverage by 0.21%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #620      +/-   ##
============================================
+ Coverage     65.14%   65.36%   +0.21%     
- Complexity     1352     1357       +5     
============================================
  Files           127      127              
  Lines          6429     6412      -17     
  Branches        873      872       -1     
============================================
+ Hits           4188     4191       +3     
+ Misses         1762     1747      -15     
+ Partials        479      474       -5
Impacted Files Coverage Δ Complexity Δ
...tor/netty/http/client/HttpClientConfiguration.java 80.64% <ø> (+1.85%) 26 <0> (ø) ⬇️
...ain/java/reactor/netty/http/client/HttpClient.java 78.09% <ø> (+3.09%) 55 <0> (ø) ⬇️
...a/reactor/netty/http/client/HttpClientConnect.java 57.22% <85.71%> (+0.32%) 4 <0> (ø) ⬇️
...eactor/netty/http/server/HttpServerOperations.java 69.73% <0%> (+0.43%) 61% <0%> (ø) ⬇️
...eactor/netty/channel/ChannelOperationsHandler.java 71.14% <0%> (+0.44%) 65% <0%> (+1%) ⬆️
...ctor/netty/resources/PooledConnectionProvider.java 79.12% <0%> (+0.73%) 23% <0%> (+1%) ⬆️
...eactor/netty/http/client/HttpClientOperations.java 60.57% <0%> (+1.14%) 67% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366f301...34e644c. Read the comment docs.

By default Transfer-Encoding: chunked will be applied for those HTTP methods
for which a request body is expected. If the user wants to disable that setting
then the user can provide Content-Length via request headers and
thus Transfer-Encoding will be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants