fix #612 API for configuring pooled connection idle time #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
reviewed
Jul 29, 2019
| .delayUntil(ch -> conn.inbound().receive())); | ||
|
|
||
| ChannelId id1 = id.blockLast(Duration.ofSeconds(30)); | ||
| Mono.delay(Duration.ofMillis(30)).block(); |
There was a problem hiding this comment.
is that on purpose? that feels weirder than using Thread.sleep(30) or Awaitility 😉
There was a problem hiding this comment.
;)
changed to Thread.sleep(30)
simonbasle
approved these changes
Jul 29, 2019
violetagg
force-pushed
the
conn-pool-idle-time
branch
from
41b4401
to
3f5f0aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
============================================
+ Coverage 67.05% 67.11% +0.05%
- Complexity 1427 1436 +9
============================================
Files 137 137
Lines 6714 6717 +3
Branches 871 873 +2
============================================
+ Hits 4502 4508 +6
+ Misses 1744 1743 -1
+ Partials 468 466 -2
Continue to review full report at Codecov.
|
smaldini
approved these changes
Jul 29, 2019
violetagg
force-pushed
the
conn-pool-idle-time
branch
from
3f5f0aa
to
f0729c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.