-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #612 API for configuring pooled connection idle time #792
Conversation
.delayUntil(ch -> conn.inbound().receive())); | ||
|
||
ChannelId id1 = id.blockLast(Duration.ofSeconds(30)); | ||
Mono.delay(Duration.ofMillis(30)).block(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that on purpose? that feels weirder than using Thread.sleep(30)
or Awaitility
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;)
changed to Thread.sleep(30)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick commented inline, but the change looks good to me 👍
41b4401
to
3f5f0aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
============================================
+ Coverage 67.05% 67.11% +0.05%
- Complexity 1427 1436 +9
============================================
Files 137 137
Lines 6714 6717 +3
Branches 871 873 +2
============================================
+ Hits 4502 4508 +6
+ Misses 1744 1743 -1
+ Partials 468 466 -2
Continue to review full report at Codecov.
|
3f5f0aa
to
f0729c5
Compare
No description provided.