fix #578 Switch "fixed" connection pool by default for TCP/HTTP client #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buzzardo
suggested changes
Aug 8, 2019
src/docs/asciidoc/tcp-client.adoc
Outdated
| ---- | ||
| ==== | ||
|
|
||
| NOTE: Be cautious with "`elastic`" connection pool when you expect a high load. You might experience |
There was a problem hiding this comment.
Add "an" after "with" on this line, please.
src/docs/asciidoc/tcp-client.adoc
Outdated
| @@ -302,11 +302,15 @@ public class Application { | |||
|
|
|||
| == Connection Pool | |||
|
|
|||
| By default, the `TCP` client uses an "`elastic`" connection pool. This means that the implementation creates a new channel | |||
| if someone tries to acquire a channel but none is in the pool. Also, there is no limit on the maximum concurrent channels. | |||
| By default, the `TCP` client uses a "`fixed`" connection pool with `500` as a maximum number of the channels and | |||
There was a problem hiding this comment.
"a maximum number" should be "the maximum number".
src/docs/asciidoc/tcp-client.adoc
Outdated
| By default, the `TCP` client uses an "`elastic`" connection pool. This means that the implementation creates a new channel | ||
| if someone tries to acquire a channel but none is in the pool. Also, there is no limit on the maximum concurrent channels. | ||
| By default, the `TCP` client uses a "`fixed`" connection pool with `500` as a maximum number of the channels and | ||
| `45s` as acquisition timeout. |
There was a problem hiding this comment.
Please insert "the" before "acquisition" on this line.
src/docs/asciidoc/tcp-client.adoc
Outdated
| By default, the `TCP` client uses a "`fixed`" connection pool with `500` as a maximum number of the channels and | ||
| `45s` as acquisition timeout. | ||
| This means that the implementation creates a new channel if someone tries to acquire a channel but none is in the pool. | ||
| When the maximum number of the channels in the pool is reached, new tries to acquire a channel will be delayed |
There was a problem hiding this comment.
Please change "will be" to "are".
src/docs/asciidoc/tcp-client.adoc
Outdated
| The implementation uses `FIFO` order for channels in the pool regardless of whether it is "`elastic`" or "`fixed`". | ||
| By default there is no idle time specified for the channels in the pool |
There was a problem hiding this comment.
Please add a comma after "default" and a period at the end.
src/docs/asciidoc/tcp-client.adoc
Outdated
|
|
||
| If you need a "`fixed`" connection pool, you can apply the following configuration by using | ||
| If you need a "`elastic`" connection pool, you can apply the following configuration by using |
There was a problem hiding this comment.
Please change "need a" to "need an".
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
============================================
+ Coverage 67.09% 67.13% +0.04%
- Complexity 1431 1433 +2
============================================
Files 137 137
Lines 6704 6704
Branches 862 862
============================================
+ Hits 4498 4501 +3
+ Misses 1745 1744 -1
+ Partials 461 459 -2
Continue to review full report at Codecov.
|
smaldini
approved these changes
Aug 9, 2019
violetagg
force-pushed
the
conn-pool-fixed
branch
from
04c194e
to
ded78a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.