-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #578 Switch "fixed" connection pool by default for TCP/HTTP client #812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. :)
src/docs/asciidoc/tcp-client.adoc
Outdated
---- | ||
==== | ||
|
||
NOTE: Be cautious with "`elastic`" connection pool when you expect a high load. You might experience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "an" after "with" on this line, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/docs/asciidoc/tcp-client.adoc
Outdated
@@ -302,11 +302,15 @@ public class Application { | |||
|
|||
== Connection Pool | |||
|
|||
By default, the `TCP` client uses an "`elastic`" connection pool. This means that the implementation creates a new channel | |||
if someone tries to acquire a channel but none is in the pool. Also, there is no limit on the maximum concurrent channels. | |||
By default, the `TCP` client uses a "`fixed`" connection pool with `500` as a maximum number of the channels and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a maximum number" should be "the maximum number".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/docs/asciidoc/tcp-client.adoc
Outdated
By default, the `TCP` client uses an "`elastic`" connection pool. This means that the implementation creates a new channel | ||
if someone tries to acquire a channel but none is in the pool. Also, there is no limit on the maximum concurrent channels. | ||
By default, the `TCP` client uses a "`fixed`" connection pool with `500` as a maximum number of the channels and | ||
`45s` as acquisition timeout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please insert "the" before "acquisition" on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/docs/asciidoc/tcp-client.adoc
Outdated
By default, the `TCP` client uses a "`fixed`" connection pool with `500` as a maximum number of the channels and | ||
`45s` as acquisition timeout. | ||
This means that the implementation creates a new channel if someone tries to acquire a channel but none is in the pool. | ||
When the maximum number of the channels in the pool is reached, new tries to acquire a channel will be delayed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change "will be" to "are".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/docs/asciidoc/tcp-client.adoc
Outdated
The implementation uses `FIFO` order for channels in the pool regardless of whether it is "`elastic`" or "`fixed`". | ||
By default there is no idle time specified for the channels in the pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comma after "default" and a period at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/docs/asciidoc/tcp-client.adoc
Outdated
|
||
If you need a "`fixed`" connection pool, you can apply the following configuration by using | ||
If you need a "`elastic`" connection pool, you can apply the following configuration by using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change "need a" to "need an".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
============================================
+ Coverage 67.09% 67.13% +0.04%
- Complexity 1431 1433 +2
============================================
Files 137 137
Lines 6704 6704
Branches 862 862
============================================
+ Hits 4498 4501 +3
+ Misses 1745 1744 -1
+ Partials 461 459 -2
Continue to review full report at Codecov.
|
04c194e
to
ded78a1
Compare
No description provided.