Connections now resolve with a ConnectionInterface #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the resolution value from
Stream
(which implements theDuplexStreamInterface
) to an instance implementing the newConnectionInterface
, which in turn implements theDuplexStreamInterface
.In other words: Each
ConnectorInterface
now has aconnect()
method that resolves to aConnectionInterface
.Because the
ConnectionInterface
implements the same base interfaceDuplexStreamInterface
, it behaves just like a normal stream resource, so consumer code can simply use the new typehint and continue to work unchanged.The
ConnectionInterface
also implements two new methods which are not available for the underlying stream:getRemoteAddress(): ?string
getLocalAddress(): ?string
Resolves / closes #44
Refs reactphp/reactphp#199
Refs reactphp/socket#65
Refs reactphp/socket#68