Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a CSPRNG for generating query IDs #65

Closed
wants to merge 1 commit into from

Conversation

kelunik
Copy link

@kelunik kelunik commented Jun 29, 2017

No description provided.

@WyriHaximus
Copy link
Member

Build failure is unrelated to this PR

@kelunik
Copy link
Author

kelunik commented Jun 29, 2017

Maybe just drop HHVM entirely?

@clue
Copy link
Member

clue commented Aug 10, 2017

Thanks for filing this PR! I can see where you're coming from, but can you please give some background information on why you think we should get this in? Thanks!

@kelunik
Copy link
Author

kelunik commented Aug 10, 2017

@clue Because it mitigates fake responses being accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants