Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to require PHP 7.1+ #276

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Feb 21, 2024

This changeset updates the project to require PHP 7.1+ and drop legacy PHP < 7.1 and HHVM as discussed in #271. I'm marking this as a BC break for anybody still stuck on very old PHP versions, but there's little chance this will affect any current projects otherwise.

This PR aims to contain the minimal changeset to update the PHP version requirement only. Follow-up PRs will update our APIs to leverage newer language features.

Builds on top of #269, #272, #273 and others
Refs reactphp/cache#58 and reactphp/stream#175

@WyriHaximus WyriHaximus added this to the v3.0.0 milestone Feb 21, 2024
@WyriHaximus WyriHaximus force-pushed the 3.x-raise-minimum-php-version-to-7.1PLUS branch from 8dfab30 to a6bc754 Compare February 21, 2024 06:40
@WyriHaximus WyriHaximus marked this pull request as ready for review February 21, 2024 06:45
@WyriHaximus WyriHaximus force-pushed the 3.x-raise-minimum-php-version-to-7.1PLUS branch 2 times, most recently from d62cd4e to ec578d4 Compare February 24, 2024 14:18
@clue clue force-pushed the 3.x-raise-minimum-php-version-to-7.1PLUS branch from eee05cc to 1321766 Compare May 15, 2024 15:59
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Went over your changes together with @cassifyit and addressed all outstanding issues, great work, now let's get this shipped! :shipit: :shipit: :shipit:

For the reference: Link to diff between original eee05cc and new 1321766: https://gist.github.com/clue/98910c5ec0c390225d702d897e366304)

@clue clue removed the maintenance label May 15, 2024
@clue clue force-pushed the 3.x-raise-minimum-php-version-to-7.1PLUS branch from 1321766 to cde4017 Compare May 16, 2024 06:47
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request looks good to me, let's get this in 👍

@WyriHaximus WyriHaximus merged commit f2fb5a2 into reactphp:3.x May 23, 2024
24 checks passed
@WyriHaximus WyriHaximus deleted the 3.x-raise-minimum-php-version-to-7.1PLUS branch May 23, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants