Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with stream 1.0, 0.7, 0.6, and 0.5 #2

Merged
merged 3 commits into from
May 14, 2017

Conversation

WyriHaximus
Copy link
Member

As mentioned on the roadmap in #1, support the latest stream tags as well.

@WyriHaximus WyriHaximus added this to the v0.2.0 milestone May 13, 2017
@WyriHaximus WyriHaximus requested review from jsor and clue May 13, 2017 22:01
@clue
Copy link
Member

clue commented May 13, 2017

FWIW: This does not affect BC, so we may as well release this as v0.1.1 👍

@WyriHaximus
Copy link
Member Author

FWIW: This does not affect BC, so we may as well release this as v0.1.1 👍

I was anticipating more breaking to be honest 🤓, 0.1.1 makes sense to me, what about you @jsor?

@@ -16,11 +16,11 @@
},
"require": {
"php": ">=5.3",
"react/stream": "^0.4 || ^0.3",
"react/stream": "^1.0 || ^0.7 || ^0.6 || ^0.5 || ^0.4 || ^0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't include 1.0 here, as 1.0 isn't released yet. Changes could happen that are not planned yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything between 0.7 and 1.0 will be bug fixes. Nothing major will change

@jsor
Copy link
Member

jsor commented May 14, 2017

I'm good with either.

@WyriHaximus WyriHaximus merged commit 82e0919 into reactphp:master May 14, 2017
@WyriHaximus
Copy link
Member Author

Will tag v0.1.1 tomorrow morning 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants