Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy HHVM build by downgrading Composer #30

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Fix legacy HHVM build by downgrading Composer #30

merged 1 commit into from
Apr 15, 2022

Conversation

SimonFrings
Copy link
Member

Builds on top of the work done by @clue and the discussion inside reactphp/socket#289.

I also updated the path for the CI badge.

clue
clue approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for applying the changes here as well! :shipit:

@clue clue added this to the v1.4.0 milestone Apr 13, 2022
@clue clue requested a review from WyriHaximus April 13, 2022 06:56
@WyriHaximus WyriHaximus merged commit 94e1689 into reactphp:1.x Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonFrings @WyriHaximus @clue