-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template params can only have one argument #35
Template params can only have one argument #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this should also be applied to the README documentation. @WyriHaximus is this something you can look into? 👍
eba153c
to
709e36b
Compare
@clue Just updated the README documentation and amended those changes to this PR. |
@WyriHaximus Same should also be applied to the |
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here. Refs: reactphp/promise#223
709e36b
to
b606aec
Compare
@SimonFrings Hah yeah I assumed we only do |
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here.
Refs: reactphp/promise#223