Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal refactoring to simplify buffer() function #6

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Internal refactoring to simplify buffer() function #6

merged 1 commit into from
Oct 30, 2017

Conversation

kelunik
Copy link
Contributor

@kelunik kelunik commented Oct 24, 2017

This avoids the extra Deferred and directly uses reject instead.

@kelunik
Simplify buffer function
41b8f3e 
This avoids the extra Deferred and directly uses reject instead.
@clue clue added this to the v1.1.0 milestone Oct 27, 2017
@clue clue added the easy pick label Oct 27, 2017
clue
clue approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, changes LGTM! 👍

While we're at it, does it make sense to also get rid of the below then() handler as part of this PR?

@clue clue changed the title Simplify buffer function Internal refactoring to simplify buffer() function Oct 27, 2017
WyriHaximus
WyriHaximus approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@WyriHaximus WyriHaximus merged commit 4ff79e6 into reactphp:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kelunik @jsor @WyriHaximus @clue