Run tests twice, once with, and once without coverage

We're doing this because certain tests have memory leaks only when code coverage is collected.
reactphp · Feb 22, 2020 · fa87e75 · fa87e75
1 parent be2544a
commit fa87e75
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 1 deletion.
diff --git a/.travis.yml b/.travis.yml
@@ -26,4 +26,5 @@ install:
   - composer install --no-interaction
 
 script:
-  - vendor/bin/phpunit --coverage-text
+  - ./vendor/bin/phpunit -v
+  - ./vendor/bin/phpunit -v --coverage-text --coverage-clover=./build/logs/clover.xml
diff --git a/tests/FunctionRejectTest.php b/tests/FunctionRejectTest.php
@@ -53,6 +53,10 @@ public function testWaitingForPromiseToRejectDoesNotLeaveGarbageCycles()
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = Timer\reject(0.01, $this->loop);
@@ -68,6 +72,10 @@ public function testCancellingPromiseDoesNotLeaveGarbageCycles()
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = Timer\reject(0.01, $this->loop);

diff --git a/tests/FunctionResolveTest.php b/tests/FunctionResolveTest.php
@@ -75,6 +75,10 @@ public function testWaitingForPromiseToResolveDoesNotLeaveGarbageCycles()
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = Timer\resolve(0.01, $this->loop);
@@ -90,6 +94,10 @@ public function testCancellingPromiseDoesNotLeaveGarbageCycles()
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = Timer\resolve(0.01, $this->loop);

diff --git a/tests/FunctionTimeoutTest.php b/tests/FunctionTimeoutTest.php
@@ -176,6 +176,10 @@ public function testWaitingForPromiseToResolveBeforeTimeoutDoesNotLeaveGarbageCy
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = Timer\resolve(0.01, $this->loop);
@@ -194,6 +198,10 @@ public function testWaitingForPromiseToRejectBeforeTimeoutDoesNotLeaveGarbageCyc
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = Timer\reject(0.01, $this->loop);
@@ -212,6 +220,10 @@ public function testWaitingForPromiseToTimeoutDoesNotLeaveGarbageCycles()
             $this->markTestSkipped('Not supported on legacy Promise v1 API');
         }
 
+        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+        }
+
         gc_collect_cycles();
 
         $promise = new \React\Promise\Promise(function () { }, function () {