Skip to content

Commit

Permalink
Merge pull request #41 from clue-labs/php7.4
Browse files Browse the repository at this point in the history
Run tests on PHP 7.4 and simplify test matrix
  • Loading branch information
jsor authored Mar 5, 2020
2 parents 0f6e328 + 53313fa commit fda8533
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
23 changes: 11 additions & 12 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,25 +1,24 @@
language: php

php:
# - 5.3 # requires old distro, see below
- 5.4
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3
- hhvm # ignore errors, see below

# lock distro so new future defaults will not break the build
dist: trusty

matrix:
include:
- php: 5.3
dist: precise
- php: 5.4
- php: 5.5
- php: 5.6
- php: 7.0
- php: 7.1
- php: 7.2
- php: 7.3
- php: 7.4
- php: hhvm-3.18
install: composer require phpunit/phpunit:^5 --dev --no-interaction # requires legacy phpunit
allow_failures:
- php: hhvm
- php: hhvm-3.18

install:
- composer install --no-interaction
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"react/promise": "^2.7.0 || ^1.2.1"
},
"require-dev": {
"phpunit/phpunit": "^6.4 || ^5.7 || ^4.8.35"
"phpunit/phpunit": "^7.0 || ^6.4 || ^5.7 || ^4.8.35"
}
}
1 change: 1 addition & 0 deletions tests/FunctionRejectTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public function testWaitingForPromiseToRejectDoesNotLeaveGarbageCycles()
}

gc_collect_cycles();
gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on

$promise = Timer\reject(0.01, $this->loop);
$this->loop->run();
Expand Down

0 comments on commit fda8533

Please sign in to comment.