-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support collection operations #15
Comments
The above example is also part of the documentation (#14). However, it does currently not describe how cancellation of promise collections works. |
Cancellation of promise collections should be handled within react/promise but is currently not supported. Calling cancel() on the promise returned by all/any/some etc. could be forwarded to all promises of the collection. |
Thanks the feedback! I've just filed reactphp/promise#33 to keep track of this. |
In the meantime, we might consider adding helper functions like |
I think we should better invest the time to implement this cleanly in react/promise. Will look at it in the next week. |
I agree that it makes more sense to keep relying on promise primitives instead of duplicating similar logic here 👍 I'll assume this is resolved and will close this for now, please feel free to report back otherwise 👍 |
What is the recommended way to wait for a timeout of multiple promises?
react/promise provides several promise collection primitives, which all have valid use cases.
One might assume the following is the way to go:
How does this cope with cancellation support? (Refs #9 and #3)
The text was updated successfully, but these errors were encountered: