Cancellation of promise collections #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
changed the title
|
ping for review @cboden @clue @WyriHaximus |
|
LGTM, 2.3 👍 (unless I missed something there isn't any BC break so 2.3 seems more appropriate then 3.0) |
This reverts commit 173d8f9. Note: The task must be kept on the queue until after it is called. Otherwise drain() will be called recursively.
|
I'm planning to add this to 3.0. |
|
Changes LGTM 👍 Personally, I would tend towards getting this into v2.3 first and then subsequently into v3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow cancellation of promises returned by functions working on promise collections.
Closes #33