Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TimeoutException legacy API by using explicit type casts #52

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

clue
Copy link
Member

@clue clue commented Dec 5, 2021

This changeset improves the TimeoutException legacy API by using explicit type casts. This simplifies the logic implemented in #50 but otherwise preserves the exact same behavior.

Builds on top of #50 and #49

@clue clue added this to the v1.8.0 milestone Dec 5, 2021
@clue clue requested a review from WyriHaximus December 5, 2021 15:45
@WyriHaximus WyriHaximus merged commit 9ccdc9b into reactphp:master Dec 5, 2021
@clue clue deleted the casts branch December 5, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants