Optimize Promise v3 API compatibility to avoid hitting autoloader #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
approved these changes
Mar 7, 2022
This was referenced Jun 17, 2022
This was referenced Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor changeset optimizes the Promise v3 API compatibility to avoid hitting the potentially expensive autoloader for each invocation. Instead of checking the
CancellablePromiseInterface(removed in Promise v3 via reactphp/promise#75), this now uses the same checks (duck-typing) also present in theReact\Promise\resolve()function. This also improves static analysis and IDE support as it will no longer reference a class that will no longer be available in Promise v3.Builds on top of #54 and #37