Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferedSink: Remove progress notifications #24

Merged
merged 1 commit into from
Jan 19, 2016
Merged

BufferedSink: Remove progress notifications #24

merged 1 commit into from
Jan 19, 2016

Conversation

jsor
Copy link
Member

@jsor jsor commented Jun 23, 2015

This PR removes triggering progress notifications on the promise returned by BufferedSink.

I always recommend to avoid the progression API of promises (it's underspecified, has subtle problems and has little to do with promises).

If you need to listen on data events, use the ReadableStream directly.

@WyriHaximus
Copy link
Member

LGTM 👍 && +1

@clue
Copy link
Member

clue commented Sep 4, 2015

LGTM 👍

For the reference: See reactphp/promise#32 for some background

cboden added a commit that referenced this pull request Jan 19, 2016
BufferedSink: Remove progress notifications
@cboden cboden merged commit 5839cc8 into reactphp:master Jan 19, 2016
@cboden cboden added this to the v0.4.4 milestone Jan 19, 2016
@clue
Copy link
Member

clue commented Mar 15, 2016

I think we all agree that we want to remove the promise progression API and getting this in is the right thing to do 👍

However, this currently targets the v0.4.4 milestone and dropping this feature ought to be considered a BC break. This means we would have to move this (and all following PRs) to a future v0.5.0 milestone.

As such, my vote would be to revert this PR for now so that we get the other changes out. We should reconsider this for the v0.5.0 release. /cc @cboden, @jsor, @WyriHaximus

@jsor
Copy link
Member Author

jsor commented Mar 15, 2016

Oh yes, i wasn't aware this has already been merged. 👍 for reverting.

@clue
Copy link
Member

clue commented Aug 15, 2016

For the reference: This has been reverted via #44 and will not end up in any release.

#45 will likely remove the whole class in the next major release.

@clue clue removed this from the v0.4.4 milestone Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants