Skip to content

Commit

Permalink
fix: add back padding to lists in callouts (#126)
Browse files Browse the repository at this point in the history
[<img height=20 src=https://readme.com/static/favicon.ico align=center>][demo] | Fixes CX-16
:---:|:---:

## 🧰 Changes

* reverts removing left padding from lists in callouts

## 🧬 QA & Testing

- [Broken on production][prod].
- [Working in this PR app][demo].

[demo]: https://markdown-pr-126.herokuapp.com/#callouts
[prod]: https://kjp.readme.io/docs/content
  • Loading branch information
kellyjosephprice authored Feb 11, 2021
1 parent 72c4475 commit 184c238
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions components/Callout/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
margin-left: $l-offset;
position: relative;
}
> ul, > ol {
padding-left: 0;
ul, ol {
padding-left: 1.3em;
}

a {
Expand Down
12 changes: 6 additions & 6 deletions example/Demo.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,24 @@ const terms = [
},
];

function DemoContent({ ci, children, fixture, name, onChange, opts }) {
const DevOnly = props => !ci && props.children;
const Maybe = ({ when, children }) => when && children;

function DemoContent({ ci, children, fixture, name, onChange, opts }) {
return (
<React.Fragment>
<DevOnly>
<Maybe when={!ci}>
<div className="rdmd-demo--editor">
<div className="rdmd-demo--editor-container">
{children}
<textarea name="demo-editor" onChange={onChange} value={fixture} />
</div>
</div>
</DevOnly>
</Maybe>
<div className="rdmd-demo--display">
<section id="hub-content">
<DevOnly>
<Maybe when={!ci}>
<h2 className="rdmd-demo--markdown-header">{name}</h2>
</DevOnly>
</Maybe>
<div id="content-container">
<div className="markdown-body">{markdown(fixture, opts)}</div>
<section className="content-toc">{reactTOC(reactProcessor().parse(fixture), opts)}</section>
Expand Down
2 changes: 2 additions & 0 deletions example/demo.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import '../styles/main.scss';

#rdmd-demo {
--rdmd-demo-container: 1400px;
--rdmd-demo-content-width: 600px;
Expand Down

0 comments on commit 184c238

Please sign in to comment.