-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(tables): fix tables overflowing divs and unaligned borders (#160)
## 🧰 Changes - add `overflow: auto` to `.rdmd-table-inner` to allow large tables to scroll as per the request in: https://linear.app/readme-io/issue/CX-179/tables-no-longer-scrolling-horizontally - remove the `:after` border and replace it with a border applied directly to the table (also, nests `:first-child` CSS rules under the new `table` rule) - sort CSS properties and lints CSS Separated the linting/sorting changes into a separate commit for easier review: Content changes commit: 8134338 Just linting and sorting fixes commit: ba6a949 ## 🧬 QA & Testing - Do long tables with multiple columns that were built with the table widget now show correctly and... - stay inside their containing div? - don't appear to have extra columns? - don't appear to have a line through the first overflow column? (see video in https://linear.app/readme-io/issue/CX-179/tables-no-longer-scrolling-horizontally) Fixes CX-179
- Loading branch information
1 parent
2c201c5
commit aa5fc94
Showing
4 changed files
with
28 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ node_modules | |
.vscode/ | ||
*.code-* | ||
*.sublime-* | ||
*.stylelintrc.json | ||
|
||
.DS_Store | ||
|
||
|
Binary file modified
BIN
+44 Bytes
(100%)
...sual-regression-tests-rdmd-syntax-renders-callouts-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+60 Bytes
(100%)
...visual-regression-tests-rdmd-syntax-renders-tables-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters