Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundlewatch): honor skip commit message #101

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Dec 17, 2020

🧰 Changes

Our bundle analysis CI/CD workflow was running on release commits, as you can see here.

- [x] Prevent bundle watch from running on release commits by honoring `SKIP CI` commit message.
- [x] Minor GH workflow YAML reformatting.
@rafegoldberg rafegoldberg requested review from a team, dok and thenaomiday and removed request for a team December 17, 2020 16:31
@rafegoldberg
Copy link
Contributor Author

rafegoldberg commented Dec 17, 2020

lol... I clearly didn't think too hard when I included ”SKIP CI” in my commit message—now tests and bundle analysis aren't running on this PR! (Should be fine once we squash and merge this, though.)

@rafegoldberg rafegoldberg changed the title fix(bundlewatch): honor SKIP CI commit message fix(bundlewatch): honor skip commit message Dec 17, 2020
@rafegoldberg rafegoldberg merged commit 796bc9c into next Dec 17, 2020
@rafegoldberg rafegoldberg deleted the fix/bundlewatch-honors-skipci-flag branch December 17, 2020 17:18
rafegoldberg pushed a commit that referenced this pull request Dec 17, 2020
## Version 6.24.1-next.4

### 🛠 Fixes & Updates

* **bundlewatch:** honor skip commit message ([#101](#101)) ([796bc9c](796bc9c))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

This PR was released!

🚀 Changes included in v6.24.1-next.4

rafegoldberg pushed a commit that referenced this pull request Jan 21, 2021
## Version 6.25.0

### 🛠 Fixes & Updates

* add variables and glossary items to TOC ([#115](#115)) ([94e505d](94e505d))
* **deps:** bump [@readme](https://github.com/readme) packages ([#98](#98)) ([8f54042](8f54042))
* **deps-dev:** bump @babel/core from 7.11.0 to 7.12.9 ([2234951](2234951))
* **deps-dev:** bump @readme/variable to v10.0.7 ([d6006d6](d6006d6))
* **deps-dev:** bump css-loader from 3.6.0 to 5.0.1 ([2849a7d](2849a7d))
* **deps-dev:** bump node-sass from 4.14.1 to 5.0.0 ([576ac1e](576ac1e))
* **deps-dev:** bump sass-loader from 7.3.1 to 10.1.0 ([ba4b402](ba4b402))
* **deps-dev:** bump terser-webpack-plugin from 3.0.8 to 4.2.3 ([979b1ec](979b1ec))
* **deps-dev:** bump webpack-merge from 4.2.2 to 5.4.0 ([3c08dc9](3c08dc9))
* don't run eslint on `test.watch` ([#102](#102)) ([59a6dfe](59a6dfe))
* **bundlewatch:** honor skip commit message ([#101](#101)) ([796bc9c](796bc9c))
* **release:** trigger on deps and deps-dev chores ([bcf7569](bcf7569))
* **webpack:** update merge import ([74d6e8a](74d6e8a))
* update release note sections ([2bb84fe](2bb84fe))
* **deps:** update various dev dependencies ([#97](#97)) ([1506072](1506072))
* user script extraction and execution ([#100](#100)) ([3eeeee9](3eeeee9))

### 📘 Tests & Docs

* sync exported markdown to RDMD site ([#105](#105)) ([8651c88](8651c88))
* update docs to latest markdown ([#107](#107)) ([239d0df](239d0df))

### ✨ New & Improved

* visual regression testing and dev server app ([#94](#94)) ([0774166](0774166))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

This PR was released!

🚀 Changes included in v6.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants