Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add variables and glossary items to TOC #115

Merged
merged 12 commits into from
Jan 21, 2021

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Jan 5, 2021

Demo 🎫 Ticket

🧰 Changes

Previously, if adding a variable or glossary item to a heading, it would
not get rendered in the table of contents. This PR adds glossary terms
and variables to the table of contents parser to fix that.

@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 5, 2021 01:32 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 5, 2021 19:21 Inactive
@kellyjosephprice kellyjosephprice changed the title Fix/glossary markdown fix: add variables and glossary items to TOC Jan 5, 2021
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 5, 2021 19:30 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 5, 2021 20:40 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 19, 2021 22:19 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 19, 2021 22:23 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 19, 2021 22:56 Inactive
@kellyjosephprice kellyjosephprice added the bug Something isn't working label Jan 20, 2021
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 20, 2021 00:44 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 20, 2021 01:10 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 20, 2021 17:29 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-115 January 20, 2021 17:35 Inactive
@kellyjosephprice kellyjosephprice marked this pull request as ready for review January 20, 2021 17:42
@kellyjosephprice kellyjosephprice requested review from a team, domharrington and dok and removed request for a team January 20, 2021 17:42
Copy link
Contributor

@dok dok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out as issues! LGTM!

@kellyjosephprice kellyjosephprice merged commit 94e505d into next Jan 21, 2021
@kellyjosephprice kellyjosephprice deleted the fix/glossary-markdown branch January 21, 2021 18:09
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.25.0-next.2

@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants