fix: pinned callouts dont render body #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a call to .splice() on the Callout component's children. Modifying the children meant that the component couldn't render twice, which happens when the callout is pinned to the sidebar. It's rendered once for spacing, then again for display.
kellyjosephprice
requested review from
a team,
rafegoldberg and
billhimmelsbach
and removed request for
a team
rafegoldberg
pushed a commit
that referenced
this pull request
Nov 12, 2020
|
This PR was released!🚀 Changes included in v6.22.2 |
kellyjosephprice
added a commit
to readmeio/api-explorer
that referenced
this pull request
Nov 12, 2020
erunion
added a commit
to readmeio/api-explorer
that referenced
this pull request
Nov 13, 2020
* fix(markdown): pinned callouts not rendering body readmeio/markdown#73 https://app.asana.com/0/1178132843162889/1198496636781214/f * chore(deps): removing @readme/markdown from the root pkg because its not used Co-authored-by: Jon Ursenbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This removes a call to .splice() on the Callout component's children.
Modifying the children meant that the component couldn't render twice,
which happens when the callout is pinned to the sidebar. It's rendered
once for spacing, then again for display.
Writing a test using enzyme is somewhere between not possible and
contrived. A follow-up PR in the api-explorer will test this.
#35