Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrating image borders #977

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: migrating image borders #977

merged 2 commits into from
Sep 27, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Sep 27, 2024 •
edited
Loading

PR App Ref CX-1110

🧰 Changes

Fixes migrating image borders.

Yet-another-image-prop we missed. I wasn't aware that magic block images were only storing the border as a className in the ast. Oops.

After the migration, it should only be stored as an attribute on an image-block node.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice marked this pull request as ready for review September 27, 2024 18:47
trishaprile
trishaprile approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@trishaprile trishaprile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kellyjosephprice kellyjosephprice merged commit c5ff7cd into next Sep 27, 2024
13 checks passed
@kellyjosephprice kellyjosephprice deleted the fix/image-borders branch September 27, 2024 19:28
rafegoldberg pushed a commit that referenced this pull request Sep 27, 2024
@semantic-release-bot
build(release): 🚀 v7.6.2 🦉
a960433 
## Version 7.6.2

### 🛠 Fixes & Updates

* migrating callouts ([#978](#978)) ([df0cb27](df0cb27))
* migrating image borders ([#977](#977)) ([c5ff7cd](c5ff7cd))
* migrating magic block tables with breaks ([#976](#976)) ([b5092f2](b5092f2))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishaprile trishaprile trishaprile approved these changes

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyjosephprice @rafegoldberg @trishaprile