fix: migrating magic block tables with breaks #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+378
to
+387
| ● One | ||
| ● Two |
There was a problem hiding this comment.
These newlines are unfortunate, but they render ok.
rafegoldberg
approved these changes
Sep 27, 2024
Comment on lines
+33
to
+35
| visit(cell, 'break', (_, index, parent) => { | ||
| parent.children.splice(index, 1, { type: 'text', value: '\n' }); | ||
| }); |
There was a problem hiding this comment.
so this just converts breaks to a "\n" character? (any chance that'll break Shift+Return sequences within table cells? or any other potential externalities?)
There was a problem hiding this comment.
It shouldn't, the editor doesn't create break nodes explicitly, but leaves it up the the current rendering library to decide how to serialize newlines. This is only an issue because remark < v8 used break nodes, but remark >=9 doesn't and just leaves the newlines in place.
This code should only trigger during the migration.
|
This PR was released!🚀 Changes included in v7.6.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes breaks in magic block tables.
🧬 QA & Testing