fix(magic-block-parser): handle excess table data #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old magic block syntax allowed shrinking the dimensions of a table, and would leave the data in place. Unknown if that's a bug or a feature. In any event, the new engine should needs to handle that.
kellyjosephprice
requested review from
a team,
domharrington and
emilyskuo
and removed request for
a team
__tests__/helpers.js
Outdated
| }; | ||
|
|
||
| module.exports.silenceConsole = fn => { | ||
| const potentialSpies = new Proxy({}, consoleStubHandler); |
There was a problem hiding this comment.
I regret trying to be cute here. I realized you can't use this and not write an expectation, since you have to call the dynamic getter.
| const wrap = mount(markdown.react(fx)); | ||
| return expect(wrap.html()).toMatchSnapshot(); | ||
|
|
||
| silenceConsole()(error => { |
There was a problem hiding this comment.
Is this to quieten the console.logs during testing?
There was a problem hiding this comment.
Yes, there's a caught error that prints to error
rafegoldberg
approved these changes
Nov 30, 2020
|
This PR was released!🚀 Changes included in v6.23.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
The old magic block syntax allowed shrinking the dimensions of a table,
and would leave the data in place. Unknown if that's a bug or a feature.
In any event, the new engine should needs to handle that.