feat: mdx-less reusable content #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
force-pushed
the
feat/mdx-less-rc
branch
from
b0ace0d
to
3baf2a8
Compare
Closed
trishaprile
approved these changes
Aug 25, 2023
kevinports
approved these changes
Aug 28, 2023
| expect(tree.children[2].children[0].value).toBe('After'); | ||
| }); | ||
|
|
||
| it('should parse a reusable content block that is not defined', () => { |
There was a problem hiding this comment.
Suggested change
| it('should parse a reusable content block that is not defined', () => { | |
| it('should not parse a reusable content block that is not defined', () => { |
If I'm reading this test case correctly, it doesn't get parsed right?
There was a problem hiding this comment.
Err, I think it's still getting parsed, per se. It's just empty? Maybe it could be clearer with "should insert an empty node if the reusable content block is not defined"
There was a problem hiding this comment.
Ah yeah that makes more sense 👍
|
This PR was released!🚀 Changes included in v6.68.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds support for Reusable Content!
This PR adds a transformer to convert
htmlnodes intoreusable-contentnodes. If the so named content node has been passed in viareusableContent, then the parsedmdsatis inserted into place. This PR also adds a compiler for writing back out tomd.The syntax is meant to match html/JSX so we have compatibility with future MDX.
🧬 QA & Testing