Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tables #938

Merged
merged 6 commits into from
Jul 12, 2024
Merged

fix: tables #938

merged 6 commits into from
Jul 12, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Jul 10, 2024 •
edited
Loading

PR App RM-9793

🧰 Changes

Changes how tables are saved as JSX.

The align attribute is stored on the Table component, as well as the table cells:

<Table align={["center", "center"]}>
  <thead>
    <tr>
      <th style={{ textAlign: 'center' }}>Hi!</th>
      <th style={{ textAlign: 'center' }}>Hello!</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td style={{ textAlign: 'center' }}>Bye!</td>
      <td style={{ textAlign: 'center' }}>Bye Bye!</td>
    </tr>
  </tbody>
</Table>

It also includes some cleanup of code that's not being used, namely html, esast, and hastFromHtml. hastFromHtml was going to be used for search indexing, but I think we're going to switch to much simpler parsing of just the hast.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta July 10, 2024 23:35
jennspencer
jennspencer reviewed Jul 11, 2024
View reviewed changes
__tests__/transformers/readme-components.test.ts
@@ -6,7 +6,7 @@ describe('Readme Components Transformer', () => {
{ md: '<Code />', type: 'code' },
{ md: '<CodeTabs />', type: 'code-tabs' },
{ md: '<Image />', type: 'image-block' },
{ md: '<Table />', type: 'table' },
{ md: '<Table />', type: 'tableau' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@kellyjosephprice kellyjosephprice marked this pull request as ready for review July 11, 2024 00:35
@kellyjosephprice kellyjosephprice marked this pull request as draft July 11, 2024 00:35
@kellyjosephprice
Copy link
Collaborator Author

Not ready, I keep forgetting.

@kellyjosephprice kellyjosephprice marked this pull request as ready for review July 11, 2024 23:15
trishaprile
trishaprile approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@trishaprile trishaprile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and looks really good :)

@kellyjosephprice kellyjosephprice merged commit 1cbb175 into beta Jul 12, 2024
11 checks passed
@kellyjosephprice kellyjosephprice deleted the fix/hast branch July 12, 2024 03:48
rafegoldberg pushed a commit that referenced this pull request Jul 12, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.73 🦉
617c05a 
## Version 6.75.0-beta.73

### 🛠 Fixes & Updates

* tables ([#938](#938)) ([1cbb175](1cbb175))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennspencer jennspencer jennspencer left review comments

@trishaprile trishaprile trishaprile approved these changes

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kellyjosephprice @rafegoldberg @jennspencer @trishaprile