fix(img): set src properly for magic image blocks #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
commented
Aug 26, 2024
| @@ -40,6 +40,8 @@ const readmeToMdx = (): Transform => tree => { | |||
|
|
|||
| visit(tree, 'image', (image, index, parent) => { | |||
| if (!('data' in image)) return; | |||
|
|
|||
| if ('url' in image) image.data.hProperties.src = image.url; | |||
There was a problem hiding this comment.
This is the "meat" of the solution. Honestly, I don't love having to do this here, since it feels to me like this should be happening in the imageTransformer? or am I misunderstanding the Unified order-of-ops here, or something?
There was a problem hiding this comment.
Yea, it seems like there might be some duplication of code. But this seems for now.
kellyjosephprice
approved these changes
Aug 26, 2024
rafegoldberg
pushed a commit
that referenced
this pull request
Aug 26, 2024
## Version 7.3.0 ### ✨ New & Improved * add downstream styles ([#953](#953)) ([0b1b52d](0b1b52d)) ### 🛠 Fixes & Updates * **img:** set src properly for magic image blocks ([#952](#952)) ([8f71fce](8f71fce)), closes [/github.com//pull/952/files#diff-9b10647639421f1135101ae63ca87780ab63af9e81c8da0b00ea6d0ddd08b8b6R26-R50](https://github.com/readmeio//github.com/readmeio/markdown/pull/952/files/issues/diff-9b10647639421f1135101ae63ca87780ab63af9e81c8da0b00ea6d0ddd08b8b6R26-R50) <!--SKIP CI-->
|
This PR was released!🚀 Changes included in v7.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
urlfield to<Image[src]>🧬 QA & Testing
Pull this branch down and try running the new test in the
images.test.tsfile.