Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate emphasis #974

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix: migrate emphasis #974

merged 3 commits into from
Sep 26, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Sep 26, 2024 •
edited
Loading

PR App RM-10622

🧰 Changes

Trims whitespace surrounding emphasis content.

** bold **

Will get serialized to:

**bold**

We should probably remove this once everything is migrated to MDX.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice marked this pull request as ready for review September 26, 2024 02:05
rafegoldberg
rafegoldberg approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests locally against some weird syntax and this seems to work a treat! 👌

__tests__/compilers/compatability.test.tsx Outdated Show resolved Hide resolved
@kellyjosephprice kellyjosephprice merged commit 45279f3 into next Sep 26, 2024
13 checks passed
@kellyjosephprice kellyjosephprice deleted the fix/migrate-phrasing-content branch September 26, 2024 16:53
rafegoldberg pushed a commit that referenced this pull request Sep 26, 2024
@semantic-release-bot
build(release): 🚀 v7.6.1 🦉
26b9b8d 
## Version 7.6.1

### 🛠 Fixes & Updates

* migrate emphasis ([#974](#974)) ([45279f3](45279f3))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@trishaprile trishaprile Awaiting requested review from trishaprile

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellyjosephprice @rafegoldberg