fix: tables with inline code with newlines #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
requested review from
kevinports,
rafegoldberg and
trishaprile
rafegoldberg
approved these changes
Sep 30, 2024
| @@ -19,6 +19,8 @@ const alignToStyle = (align: 'left' | 'center' | 'right' | null) => { | |||
|
|
|||
| const isTableCell = (node: Node) => ['tableHead', 'tableCell'].includes(node.type); | |||
|
|
|||
| const isLiteral = (node: Node): node is Literal => 'value' in node; | |||
There was a problem hiding this comment.
Wait, I know about as but what is the meaning of is in TS???
There was a problem hiding this comment.
I don't know the term off hand, but it means the function is restricting the type?
Comment on lines
+44
to
+45
| visit(cell, isLiteral, (node: Literal) => { | ||
| if (node.value.match(/\n/)) { |
There was a problem hiding this comment.
What is a "literal" node anyways?
There was a problem hiding this comment.
Anything with a text value. I think that's text, inlineCode, code, html, yaml
| 'h-0': 'Field', | ||
| 'h-1': 'Description', | ||
| '0-0': 'orderby', | ||
| '0-1': '`{\n "field": "ID",\n "type": "ASC"\n }`', |
There was a problem hiding this comment.
What would happen if they'd wrapped this in a code block instead of an inline? Would that "just work"?
There was a problem hiding this comment.
I think so. RDMD should compile it back to magic block.
kellyjosephprice
deleted the
fix/migrating-tables-with-codes-with-newlines
branch
rafegoldberg
pushed a commit
that referenced
this pull request
Sep 30, 2024
|
This PR was released!🚀 Changes included in v7.6.3 |
kellyjosephprice
restored the
fix/migrating-tables-with-codes-with-newlines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes migrating tables with inline code with newlines.
Our previous check for converting markdown tables to JSX only scanned text nodes. That would skip inline code and inline html. Uh oh.
🧬 QA & Testing