feat(syntaxhighlighter): line highlighting #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Additional refactor for single loop style implementation
…ghlighter into feat/line-highlighter
- Updated name schemes - Reuse components
- Moving standalone function calls outside parent - Consolidating component declaration
gratcliff
changed the title
runnabro
approved these changes
Sep 14, 2020
gratcliff
added a commit
that referenced
this pull request
Sep 15, 2020
* feat(codeeditor): tree restructuring - Adding codeEditor structure from ui lib - Restructuring src to be more comprehensive * feat(codeeditor): full integration of ui codeeditor - Added sass support in webpack - Consolidating utils for shared use - Porting ui code editor * chore: lint cleanup * feat(codeeditor): geeneral polish - Tweaking linters for new file structure - Test updates - Prettyfying * feat(codeeditor): moving to single configurable export * feat(editor): adding support for linenumbers in runmode * feat(editor): beginning conditional line styling" * style(code editor): matching parent classes * feat(editor): wrapping lines in divs for styling * style(code mirror): add remaining styles and highlight styles * style(code mirror): use proper highlight/overlay classes * fix: blocking linenumbers from selection * style(code mirror): preserve highlight on hover * feat(syntaxhighlighter): line highlighting (#6) * feat: attempt at line highlighting w comments * feat: it works and is less ugly now * fix: blocking linenumbers from selection * chore: small eslint fix to pass tests * feat(highlighting): minor refactor - Updated name schemes - Reuse components * feat(highlighting): further refactoring - Moving standalone function calls outside parent - Consolidating component declaration * fix(highlighting): applying overlay to deadspace * chore(coremirror): remove extra class * chore: adding variable Co-authored-by: Gabriel Ratcliff <[email protected]> Co-authored-by: Tony Li <[email protected]> * chore: tests and docs * chore: documentation - Updating readme.md to provide proper use cases and option documentation - Cleanup per review comments * chore: documenting editable use case * fix: canonical named export * chore: adding homepage * chore: dev and prod optimization * chore: webpack externals - Excluding React and react-dom from webpack built as to avoid conflicts - Replicating import syntax in test bed - Cleaning up package.json * chore: fixing pr comment * fix: breaking out styled syntax highlighter into seperate function * chore: removing comment Co-authored-by: Gabe Ratcliff <[email protected]> Co-authored-by: Tony Li <[email protected]> Co-authored-by: Julia Hotaling <[email protected]>
kellyjosephprice
pushed a commit
to readmeio/markdown
that referenced
this pull request
Nov 9, 2020
### 🧰 Changes Been a while since the syntax highlighter has been updated here and since I added support for TOML to it today, we should get it up to date here so Markdown code blocks with that language should get highlighted. Includes a fix for how codemirror renders syntax highlighting as `div`s. ### 📖 Release Notes #### 10.2.0 (2020-10-29) * feat: adding support for TOML highlighting (#26) ([b2e617b](readmeio/syntax-highlighter@b2e617b)), closes [#26](readmeio/syntax-highlighter#26) #### <small>10.1.2 (2020-10-26)</small> * fix: isolating regex check to highlightmode option (#25) ([aec7c81](readmeio/syntax-highlighter@aec7c81)), closes [#25](readmeio/syntax-highlighter#25) #### <small>10.1.1 (2020-10-23)</small> * fix: check for \n in CodeMirror runmode (#23) ([66444f4](readmeio/syntax-highlighter@66444f4)), closes [#23](readmeio/syntax-highlighter#23) #### 10.1.0 (2020-10-22) * chore: moving react and react-dom into being peerdeps (#24) ([d1826d7](readmeio/syntax-highlighter@d1826d7)), closes [#24](readmeio/syntax-highlighter#24) #### <small>10.0.1 (2020-10-12)</small> * feat(context): exporting context provider (#22) ([1dc67c0](readmeio/syntax-highlighter@1dc67c0)), closes [#22](readmeio/syntax-highlighter#22) * fix(readonly): wip styled output (#21) ([82b99ab](readmeio/syntax-highlighter@82b99ab)), closes [#21](readmeio/syntax-highlighter#21) #### 10.0.0 (2020-10-05) * fix(bundle): client and server compatibility (#20) ([bd4362b](readmeio/syntax-highlighter@bd4362b)), closes [#20](readmeio/syntax-highlighter#20) * chore(deps-dev): bump @commitlint/cli from 9.1.2 to 11.0.0 (#10) ([c466e8d](readmeio/syntax-highlighter@c466e8d)), closes [#10](readmeio/syntax-highlighter#10) * chore(deps-dev): bump @commitlint/config-conventional (#19) ([b700798](readmeio/syntax-highlighter@b700798)), closes [#19](readmeio/syntax-highlighter#19) * chore(deps-dev): bump css-loader from 3.6.0 to 4.3.0 (#16) ([e3c0c67](readmeio/syntax-highlighter@e3c0c67)), closes [#16](readmeio/syntax-highlighter#16) * chore(deps-dev): bump eslint from 7.8.0 to 7.10.0 (#11) ([d5e30e0](readmeio/syntax-highlighter@d5e30e0)), closes [#11](readmeio/syntax-highlighter#11) * chore(deps-dev): bump husky from 4.2.5 to 4.3.0 (#18) ([7e437fe](readmeio/syntax-highlighter@7e437fe)), closes [#18](readmeio/syntax-highlighter#18) * chore(deps-dev): bump prettier from 2.1.1 to 2.1.2 (#14) ([f3c572f](readmeio/syntax-highlighter@f3c572f)), closes [#14](readmeio/syntax-highlighter#14) * chore(deps-dev): bump sass-loader from 10.0.1 to 10.0.2 (#12) ([2e9a2e9](readmeio/syntax-highlighter@2e9a2e9)), closes [#12](readmeio/syntax-highlighter#12) * chore(deps-dev): bump terser-webpack-plugin from 4.1.0 to 4.2.2 (#15) ([9c0d3dc](readmeio/syntax-highlighter@9c0d3dc)), closes [#15](readmeio/syntax-highlighter#15) * chore(deps-dev): bump webpack from 4.44.1 to 4.44.2 (#17) ([828adca](readmeio/syntax-highlighter@828adca)), closes [#17](readmeio/syntax-highlighter#17) * chore(deps): bump actions/checkout from v2.3.2 to v2.3.3 (#9) ([6f1fda0](readmeio/syntax-highlighter@6f1fda0)), closes [#9](readmeio/syntax-highlighter#9) * chore(deps): bump codemirror from 5.57.0 to 5.58.1 (#13) ([7d7c7b3](readmeio/syntax-highlighter@7d7c7b3)), closes [#13](readmeio/syntax-highlighter#13) #### <small>9.0.1 (2020-09-16)</small> * chore: line number dom elements updated to use span (#8) ([85aeb0e](readmeio/syntax-highlighter@85aeb0e)), closes [#8](readmeio/syntax-highlighter#8) * fix(highlighting): fixing an issue where overlay was not applied correctly (#7) ([df2236e](readmeio/syntax-highlighter@df2236e)), closes [#7](readmeio/syntax-highlighter#7) #### 9.0.0 (2020-09-15) * feat: code editor export (#5) ([3c2baa0](readmeio/syntax-highlighter@3c2baa0)), closes [#5](readmeio/syntax-highlighter#5) [#6](readmeio/syntax-highlighter#6) * docs: adding a line break in the readme ([6819099](readmeio/syntax-highlighter@6819099)) #### <small>8.0.3 (2020-09-02)</small> * chore(deps): upgrading @readme/variable to 7.2.1 ([7ec28f3](readmeio/syntax-highlighter@7ec28f3)) #### <small>8.0.2 (2020-09-02)</small> * docs: updating a link in the contributing docs ([c539940](readmeio/syntax-highlighter@c539940)) #### <small>8.0.1 (2020-09-01)</small> * feat: setting up webpack (#4) ([fa651fc](readmeio/syntax-highlighter@fa651fc)), closes [#4](readmeio/syntax-highlighter#4) #### 8.0.0 (2020-08-31) > No breaking changes in this release, the package has just moved a new home at https://github.com/readmeio/syntax-highlighter! * chore: moving the package code into a src/ directory ([e78554e](readmeio/syntax-highlighter@e78554e)) * chore: pulling the syntax-highlighter package over from the explorer repo ([296c7de](readmeio/syntax-highlighter@296c7de)) * chore(deps-dev): bump eslint from 7.7.0 to 7.8.0 (#2) ([9789985](readmeio/syntax-highlighter@9789985)), closes [#2](readmeio/syntax-highlighter#2) * chore(deps-dev): bump jest from 26.1.0 to 26.4.2 (#3) ([c837dd7](readmeio/syntax-highlighter@c837dd7)), closes [#3](readmeio/syntax-highlighter#3) * chore(deps-dev): bump prettier from 2.0.5 to 2.1.1 (#1) ([0cfbe94](readmeio/syntax-highlighter@0cfbe94)), closes [#1](readmeio/syntax-highlighter#1) * docs: setting up changelog generation ([dcfe1db](readmeio/syntax-highlighter@dcfe1db)) * ci: adding a ci workflow for running tests ([fe631bd](readmeio/syntax-highlighter@fe631bd)) * ci: setting up dependabot ([a293e53](readmeio/syntax-highlighter@a293e53)) * test: fixing broken tests ([6257159](readmeio/syntax-highlighter@6257159))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Adding support for line highlighting in the code editor export
🧪 Testing
Provide as much information as you can on how to test what you've done.