Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niche targeting explainer page #454

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Conversation

davidfischer
Copy link
Collaborator

  • Add a page explaining niche targeting and link from the advertiser page
  • Cross-link with the similar pages demo
  • Fixed a minor bug with prefilling checkboxes
  • Should we link to our blog posts on the subject from the FAQ?

- Add a page explaining niche targeting
  and link from the advertiser page
- Cross-link with the similar pages demo
- Fixed a minor bug with prefilling checkboxes
- Should we link to our blog posts on the subject
  from the FAQ?
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! We should figure out exactly what we're calling it and use that consistently. We should also decide if we're using AI or ML on a page and stick to it.

Should we link to our blog posts on the subject from the FAQ?

Not sure. I think for now this looks great and covers similar ground.

content/pages/niche-targeting.md Outdated Show resolved Hide resolved
content/pages/similar-pages.md Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/niche-targeting.html Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/niche-targeting.html Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/niche-targeting.html Outdated Show resolved Hide resolved
@ericholscher
Copy link
Member

Feel free to merge this when you think it's ready. No need for me to take a second look. 👍

@davidfischer davidfischer merged commit 8a128f3 into main Sep 20, 2024
2 checks passed
@davidfischer davidfischer deleted the davidfischer/niche-targeting-page branch September 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants