Include readthedocssinglehtml to online builders #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this locally, it works :) |
davidfischer
approved these changes
Feb 20, 2019
stsewd
added a commit
to stsewd/readthedocs.org
that referenced
this pull request
Feb 20, 2019
This doesn't remove documentation_type completely from the footer, but makes it more clear what we are really using. We don't use `readthedocssinglehtml` as proven in readthedocs/readthedocs-sphinx-ext#58 We don't set `page` for mkdocs projects: https://github.com/rtfd/readthedocs.org/blob/f1c15d4f22af0ba7ebf762df1d49f7c28e8d01e5/readthedocs/doc_builder/backends/mkdocs.py#L207-L207 Ref readthedocs#4638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are not inserting any of our data (and some data from users, like their analytics code) in projects building with
singlehtmlpage.This also proves that we are not using this line https://github.com/rtfd/readthedocs.org/blob/6d960f14dc2433ae66dff675b4e66f30dbc606b7/readthedocs/restapi/views/footer_views.py#L103-L105
The generated page only contains one big page with the
page_slug==index.