Skip to content

Commit

Permalink
Remove logging verbosity on syncer failure (#4717)
Browse files Browse the repository at this point in the history
We get a ton of these,
but never look at them.
I don't really know if we can fix this,
but lets stop spamming Sentry
  • Loading branch information
ericholscher authored Oct 9, 2018
1 parent 90b1e52 commit c38efc8
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions readthedocs/builds/syncers.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def copy(cls, path, target, is_file=False, **__):
mkdir_cmd = ("ssh %s@%s mkdir -p %s" % (sync_user, server, target))
ret = os.system(mkdir_cmd)
if ret != 0:
log.error("Copy error to app servers: cmd=%s", mkdir_cmd)
log.debug("Copy error to app servers: cmd=%s", mkdir_cmd)
if is_file:
slash = ""
else:
Expand All @@ -74,7 +74,7 @@ def copy(cls, path, target, is_file=False, **__):
target=target))
ret = os.system(sync_cmd)
if ret != 0:
log.error("Copy error to app servers: cmd=%s", sync_cmd)
log.debug("Copy error to app servers: cmd=%s", sync_cmd)


class DoubleRemotePuller(object):
Expand All @@ -98,7 +98,7 @@ def copy(cls, path, target, host, is_file=False, **__):
)
ret = os.system(mkdir_cmd)
if ret != 0:
log.error("MkDir error to app servers: cmd=%s", mkdir_cmd)
log.debug("MkDir error to app servers: cmd=%s", mkdir_cmd)
# Add a slash when copying directories
sync_cmd = (
"ssh {user}@{server} 'rsync -av "
Expand All @@ -111,7 +111,7 @@ def copy(cls, path, target, host, is_file=False, **__):
target=target))
ret = os.system(sync_cmd)
if ret != 0:
log.error("Copy error to app servers: cmd=%s", sync_cmd)
log.debug("Copy error to app servers: cmd=%s", sync_cmd)


class RemotePuller(object):
Expand All @@ -138,7 +138,7 @@ def copy(cls, path, target, host, is_file=False, **__):
)
ret = os.system(sync_cmd)
if ret != 0:
log.error(
log.debug(
"Copy error to app servers. Command: [%s] Return: [%s]",
sync_cmd,
ret,
Expand Down

0 comments on commit c38efc8

Please sign in to comment.