Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - This page does not exist yet. #3303

Closed
techtonik opened this issue Nov 23, 2017 · 4 comments
Closed

Build - This page does not exist yet. #3303

techtonik opened this issue Nov 23, 2017 · 4 comments

Comments

@techtonik
Copy link
Contributor

Details

Hitting the Build button for the above project gives this message:


        \          SORRY            /
         \                         /
          \    This page does     /
           ]   not exist yet.    [    ,'|
           ]                     [   /  |
           ]___               ___[ ,'   |
           ]  ]\             /[  [ |:   |
           ]  ] \           / [  [ |:   |
           ]  ]  ]         [  [  [ |:   |
           ]  ]  ]__     __[  [  [ |:   |
           ]  ]  ] ]\ _ /[ [  [  [ |:   |
           ]  ]  ] ] (#) [ [  [  [ :===='
           ]  ]  ]_].nHn.[_[  [  [
           ]  ]  ]  HHHHH. [  [  [
           ]  ] /   `HH("N  \ [  [
           ]__]/     HHH  "  \[__[
           ]         NNN         [
           ]         N/"         [
           ]         N H         [
          /          N            \
         /           q,            \
        /                           \

I am logged in. If I am not logged in, RTD proposes to login.

Expected Result

Starting build, or explaining why it doesn't happen.

@humitos
Copy link
Member

humitos commented Nov 23, 2017

This is something that was changed recently at #3260.

I think the that the decision is not to show the Build button in projects where you don't have permissions. I'm creating a PR for this behaviour.

@techtonik
Copy link
Contributor Author

I like the button - it gives a hint that it is possible to rebuild docs online.

@humitos
Copy link
Member

humitos commented Nov 24, 2017

I also liked the button, but it's true that it's kind of weird to trigger builds in documentation that are not your projects.

I'm not sure if this could be a problem or not. Maybe @agjohnson can explain more about this decision.

@techtonik
Copy link
Contributor Author

I don't see how manually triggering a build is a problem for projects that you don't own on RTD. As a contributor, I like to trigger builds regardless of my status with RTD. If there is abuse in the system, it should be proven that it actually takes place and throttled, like any sane API does.

agjohnson pushed a commit that referenced this issue Nov 27, 2017
* Do not show Build button when user is not project admin

Closes #3303

* Add test to check for Build section

* Fix old test to make sure a public branch is listed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants