Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests failing with postgresql #3957

Closed
xrmx opened this issue Apr 17, 2018 · 3 comments
Closed

tests failing with postgresql #3957

xrmx opened this issue Apr 17, 2018 · 3 comments
Labels
Bug A bug

Comments

@xrmx
Copy link
Contributor

xrmx commented Apr 17, 2018

Details

We're trying to run tests against postgres to match the database we use in production.

Expected Result

tests pass

Actual Result

With the following changes required to run tests against postgres https://github.com/rtfd/readthedocs.org/compare/master...italia:testspostgres?expand=1 tests fails with this https://travis-ci.org/italia/docs.italia.it/jobs/367583533
@xrmx xrmx changed the title tests failing with postgresql tests failing with postgresql 10 Apr 17, 2018
@xrmx xrmx changed the title tests failing with postgresql 10 tests failing with postgresql Apr 17, 2018
@xrmx
Copy link
Contributor Author

xrmx commented Apr 17, 2018 •
edited
Loading

These are build failure logs against postgresql 9.6: https://travis-ci.org/italia/docs.italia.it/jobs/367631789

@xrmx xrmx mentioned this issue Apr 17, 2018
Merged
@RichardLitt RichardLitt added the Bug A bug label Apr 17, 2018
@xrmx
Copy link
Contributor Author

xrmx commented Apr 17, 2018 •
edited
Loading

For the other 50% not fixed by the PR above i've tried this but that's not it:
italia@fa39836

Any help would be much appreciated

UPDATE: I've tried to use self.integration.id but that's not it, what's that 1 supposed to be the pk of?

@stsewd
Copy link
Member

stsewd commented Apr 17, 2018

As I know, RTD uses Postgres in production.

xrmx added a commit to italia/docs.italia.it that referenced this issue Apr 18, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
6775546 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue Apr 18, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
cf829a5 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
@xrmx xrmx mentioned this issue Apr 18, 2018
Merged
xrmx added a commit to italia/docs.italia.it that referenced this issue Apr 18, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
e72ce29 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue Apr 18, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
89fa0db 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue Apr 24, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
c3b8af3 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue Apr 24, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
e7117e0 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue May 2, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
94afa8f 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue May 2, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
d337926 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue May 29, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
a58999d 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
xrmx added a commit to italia/docs.italia.it that referenced this issue May 30, 2018
@xrmx
tests: fixup url tests in test_privacy_urls
cef31de 
We have two issues. First we were checking always against the
default status_code and not the one we expected, second we can't
assume that integration id is always 1 but update urls with the
current id.

Fix readthedocs#3957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xrmx @RichardLitt @stsewd