Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using configuration file results in builder without graphviz #8672

Closed
rokroskar opened this issue Nov 11, 2021 · 5 comments
Closed

using configuration file results in builder without graphviz #8672

rokroskar opened this issue Nov 11, 2021 · 5 comments
Labels
Support Support question

Comments

@rokroskar
Copy link
Contributor

Our project contains graphviz directives and uses the sphinx graphviz extension. This has worked very well for years on RTD. A few days ago we added a .readthedocs.yaml file:

version: 2
build:
  os: ubuntu-20.04
  tools:
    python: "3.9"

sphinx:
  configuration: docs/conf.py

python:
  install:
  - requirements: docs/requirements.txt

submodules:
  include: all

If this file is in the project, dot is not found and the graphviz graphs don't render. I assume this is a problem with the builder since I can't find any place to state that graphviz should be installed/used.

@stsewd
Copy link
Member

stsewd commented Nov 11, 2021

Can you share your rtd project and repo?

@stsewd stsewd added the Needed: more information A reply from issue author is required label Nov 11, 2021
@rokroskar
Copy link
Contributor Author

sure, sorry for omitting that...

This is a build of master that doesn't find dot: https://readthedocs.org/projects/renku/builds/15244844/
And here's a build where I removed the .readthedocs.yaml file: https://readthedocs.org/projects/renku/builds/15247371/

The repo is here: https://github.com/SwissDataScienceCenter/renku

@no-response no-response bot removed the Needed: more information A reply from issue author is required label Nov 11, 2021
@humitos
Copy link
Member

humitos commented Nov 11, 2021

I found this in the logs:

generating indices... WARNING: dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting

Doesn't graphviz require an APT package to be installed to be able to render properly? Maybe graphviz. You can use https://docs.readthedocs.io/en/stable/config-file/v2.html#build-apt-packages to install it.

Please, take a look at that and let me know.

@stsewd
Copy link
Member

stsewd commented Nov 11, 2021

There are two things I see different:

But I think the main problem is the base image used in the builds, the old image has https://github.com/readthedocs/readthedocs-docker-images/blob/6e61b2a903a0a22d2c14bec5f55b01467c39fbda/Dockerfile#L23 pre-installed. You need to install the apt package graphviz or graphviz-dev https://docs.readthedocs.io/en/stable/config-file/v2.html#build-apt-packages.

@stsewd stsewd added the Support Support question label Nov 11, 2021
@rokroskar
Copy link
Contributor Author

Ah you're absolutely right @humitos and @stsewd, I totally missed that in the docs 🤦 Apologies for the noise.

What I found confusing was this line in the FAQ:

We can’t support installing random C binaries on our system, so there is another way to fix these imports.

which led me to believe that I couldn't install additional packages beyond what was already in the builder images (and I completely missed the apt part in the configuration file docs).

I added a short blurb to the FAQ here: #8676

cmarqu added a commit to cmarqu/cocotb that referenced this issue Oct 29, 2023
This makes the 'dot' binary available to sphinx.ext.inheritance-diagrams

See also readthedocs/readthedocs.org#8672

Closes cocotb#3449
cmarqu added a commit to cocotb/cocotb that referenced this issue Oct 31, 2023
Add graphviz package to doc build config, directly use SVG

This makes the 'dot' binary available to sphinx.ext.inheritance-diagrams.
See also readthedocs/readthedocs.org#8672.
Include rendered SVG directly until sphinx-doc/sphinx#10117 is fixed.

Closes #3449
imphil pushed a commit to imphil/cocotb that referenced this issue Apr 24, 2024
Add graphviz package to doc build config, directly use SVG

This makes the 'dot' binary available to sphinx.ext.inheritance-diagrams.
See also readthedocs/readthedocs.org#8672.
Include rendered SVG directly until sphinx-doc/sphinx#10117 is fixed.

Closes cocotb#3449

(cherry picked from commit 8bc6be6)
imphil pushed a commit to cocotb/cocotb that referenced this issue Apr 28, 2024
Add graphviz package to doc build config, directly use SVG

This makes the 'dot' binary available to sphinx.ext.inheritance-diagrams.
See also readthedocs/readthedocs.org#8672.
Include rendered SVG directly until sphinx-doc/sphinx#10117 is fixed.

Closes #3449

(cherry picked from commit 8bc6be6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

3 participants