Fix Travis lint issue #3551
Fix Travis lint issue #3551
Conversation
six is broken for this method, see: benjaminp/six#164
| @@ -44,7 +44,7 @@ def handle(self, *args, **options): | |||
| version = Version.objects.get(id=build['version']) | |||
| latest_build = version.builds.latest('date') | |||
| if latest_build.date > max_date: | |||
| log.warn('{0} is newer than {1}'.format( | |||
| log.warning('{0} is newer than {1}'.format( | |||
| @@ -25,6 +25,7 @@ pylint: | |||
| max-line-length: 100 | |||
| disable: | |||
| - logging-format-interpolation | |||
| - inconsistent-return-statements | |||
There was a problem hiding this comment.
I don't like this but you may don't agree.
def run_time(self):
"""Total command runtime in seconds."""
if self.start_time is not None and self.end_time is not None:
diff = self.end_time - self.start_time
return diff.secondsin that example, we are forced to put a return None as the last line of the method.
There was a problem hiding this comment.
In general, I think we should enforce consistent returns but it doesn't strictly have to be fixed in this PR. I removed this and ran it to see how many places we do this. There's around 35 functions with inconsistent returns.
There was a problem hiding this comment.
Yes, there aren't too many functions. I added disabled it globally because I think it could be different opinions on this, so we need to agree if we want those explicit return or not.
If we are going in that direction I can fix those 35 functions.
| @@ -20,7 +20,7 @@ class Meta(object): | |||
| 'largest', | |||
| ) | |||
|
|
|||
| def __init__(self, instance=None, *args, **kwargs): | |||
| def __init__(self, instance=None, *args, **kwargs): # noqa | |||
There was a problem hiding this comment.
I'm wondering if we should add keyword-arg-before-vararg to prospector.yml. Perhaps it's better to just add a few noqas and not introduce the bug any further (as you did).
There was a problem hiding this comment.
I like prospector informing about this, but there are some particular cases (like this one) that we want to make an exception. I decided to add noqa instead of pylint: disable= because the line gets to long and then pep8 start failing, so I need to also disable that one and it ends ugly.
| @@ -25,6 +25,7 @@ pylint: | |||
| max-line-length: 100 | |||
| disable: | |||
| - logging-format-interpolation | |||
| - inconsistent-return-statements | |||
There was a problem hiding this comment.
In general, I think we should enforce consistent returns but it doesn't strictly have to be fixed in this PR. I removed this and ran it to see how many places we do this. There's around 35 functions with inconsistent returns.
|
Looks good to fix our build. Can address the other lingering issues later. |
The new pylint has a couple of new features that makes our linting to fail. So, I fixed them as I think it's correct.