Added eslint rules #3768
Merged
Added eslint rules #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfischer
approved these changes
Mar 12, 2018
There was a problem hiding this comment.
Nice. I'm looking forward to having this in master. I'll know @agjohnson is always interested in JS changes so I'll leave this for a day or so for him to look at before merging.
|
Thanks @davidfischer |
|
I merged master into this branch and may have created a minor disaster in the commit stream. However, I believe this is merge ready otherwise. |
|
Actually I may have butchered this. I'm going to see if I can fix it. |
|
I had to rebase this but I believe we are now ready. |
|
Thank you very much for the contribution! This is fantastic. ✨ |
|
Thank you @davidfischer! I am more than happy to contribute 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following lint rules :
I have removed the errors that were present in the code. Now we get 51 warnings and 0 errors. Except
no-unused-varall are set toerror.indentrule is left to be added. I will make a separate PR just forindentas there are large no. of errors (more than 600) associated with adding this rule.