Refactor PublicTask into a decorator task #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Sep 21, 2018
| user = User.objects.get(pk=user_id) | ||
| for service_cls in registry: | ||
| for service in service_cls.for_user(user): | ||
| service.sync() |
There was a problem hiding this comment.
The api for defining a public task is cleaner now :D
stsewd
commented
Sep 21, 2018
readthedocs/oauth/tasks.py
Outdated
| @@ -22,20 +31,12 @@ | |||
|
|
|||
|
|
|||
| @permission_check(user_id_matches) | |||
There was a problem hiding this comment.
In the celery docs, it says that we shouldn't do this (put the task decorator down), but the task decorator overrides all function's attributes and deletes the added by permission_check, this way we can keep the added attribute.
|
I believe this is ready, I also tested it locally, it works as expected. |
stsewd
removed
the
PR: work in progress
agjohnson
approved these changes
Oct 2, 2018
| user = User.objects.get(pk=user_id) | ||
| for service_cls in registry: | ||
| for service in service_cls.for_user(user): | ||
| service.sync() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still wip, I need to update some docstrings, but I already tested it, and it works :)Fix #3974 and ref to #3973