Install latest version of pip #4938
Conversation
|
There is still the decision if use a feature flag to install the latest instead of the version that is pinned. |
Codecov Report
@@ Coverage Diff @@
## master #4938 +/- ##
==========================================
+ Coverage 76.93% 76.94% +<.01%
==========================================
Files 158 158
Lines 10039 10042 +3
Branches 1259 1259
==========================================
+ Hits 7724 7727 +3
Misses 1981 1981
Partials 334 334
|
|
|
||
| # Install latest pip first, | ||
| # so it is used when installing the other requirements. | ||
| cmd = pip_install_cmd + ['pip==18.1'] |
There was a problem hiding this comment.
Do we really expect to update this regularly? Feels like we should probably just call it with --upgrade, but I also worry about being exposed to pip bugs on release :/
There was a problem hiding this comment.
Well, the release history looks good https://pypi.org/project/pip/#history. Not sure, I'm also worry about not having control of the version in case a bug comes up from pip.
There was a problem hiding this comment.
pip is a really mature piece of software with active development. All the python ecosystem relies on it. I think it will be better to just unpin it and rely on them.
The case would be different if we are talking about a different package.
|
|
||
| # Install latest pip first, | ||
| # so it is used when installing the other requirements. | ||
| cmd = pip_install_cmd + ['pip==18.1'] |
There was a problem hiding this comment.
pip is a really mature piece of software with active development. All the python ecosystem relies on it. I think it will be better to just unpin it and rely on them.
The case would be different if we are talking about a different package.
Closes #4823