Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wipe view not CSRF exempt #5025

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 20, 2018

There is no reason to CSRF exempt this view since it's accessed via a form with POST action from the dashboard.

Related: https://github.com/rtfd/readthedocs-corporate-ops/pull/127

There is no reason to CSRF exempt this view since it's accessed via a
form with POST action from the dashboard.
@humitos humitos requested a review from a team December 20, 2018 19:39
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I don't think we use this in another part

@humitos humitos merged commit 5386e84 into master Dec 21, 2018
@humitos humitos deleted the humitos/wipe/remove-csrf-exempt branch December 21, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants