Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial structure for APIv3 #5356

Merged
merged 96 commits into from
May 9, 2019
Merged

Initial structure for APIv3 #5356

merged 96 commits into from
May 9, 2019

Commits on May 7, 2019

  1. Initial structure for APIv3

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d90abf2 View commit details
    Browse the repository at this point in the history

  2. Improve expandable fields using drf-flex-fields

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4e33c1a View commit details
    Browse the repository at this point in the history

  3. Basic throttle rates setting

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    2494cc9 View commit details
    Browse the repository at this point in the history

  4. Use a class filter to allow expansion

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6930782 View commit details
    Browse the repository at this point in the history

  5. Use methods from models instead of custom from serializer

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d0919d0 View commit details
    Browse the repository at this point in the history

  6. Improve serializers

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    7150fb2 View commit details
    Browse the repository at this point in the history

  7. Push filters file

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b1f3d81 View commit details
    Browse the repository at this point in the history

  8. Nested (under /projects/) versions endpoint 

    Listing

http /api/v3/projects/<project_slug>/versions/

Filtering

http /api/v3/projects/<project_slug>/versions/?active=true

Expand extra fields

http /api/v3/projects/<project_slug>/versions/?expand=last_build

Detail

http /api/v3/projects/<project_slug>/versions/<version_slug>/

Editing

http PATCH /api/v3/projects/<project_slug>/versions/<version_slug>/ active=true
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    73f49df View commit details
    Browse the repository at this point in the history

  9. Build endpoints 

    Listing (by project)

http /api/v3/projects/pip/builds/
http /api/v3/projects/pip/builds/?expand=config

Listing (by version in project)

http /api/v3/projects/pip/versions/19.0.3/builds/

Detail

http /api/v3/projects/pip/builds/1500/

Trigger (default version)

http POST /api/v3/projects/test-builds/builds/

Trigger (specific version)

http POST /api/v3/projects/pip/versions/19.0.3/builds/
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    2c3eecd View commit details
    Browse the repository at this point in the history

  10. Build filters 

    Filter by commit

http /api/v3/projects/pip/builds/?commit=0d755d38a894324ab495e12307ec3efd5927df88

Filter by commit (and version)

http /api/v3/projects/pip/versions/19.0.1/builds/?commit=0d755d38a894324ab495e12307ec3efd5927df88

Filter by running

http /api/v3/projects/pip/builds/?running=true

Filter by running (and version)

http /api/v3/projects/pip/versions/19.0.1/builds/?running=true
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4577fe5 View commit details
    Browse the repository at this point in the history

  11. Endpoints for related projects 

    Translations

http /api/v3/projects/pip/translations/

Subprojects

http /api/v3/projects/pip/subprojects/

Superprojects

http /api/v3/projects/pip/superprojects/
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    a043589 View commit details
    Browse the repository at this point in the history

  12. Add "links" field for Project, Version and Build

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    1936654 View commit details
    Browse the repository at this point in the history

  13. Style

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    7968af2 View commit details
    Browse the repository at this point in the history

  14. Allow . (dots) on version_slug endpoint URLs

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    cedb137 View commit details
    Browse the repository at this point in the history

  15. Make the API really browsable 

    - use DefaultRouter to get this feature
- inherit view only from methods that are allowed (using Mixin
  classes)
- add docstring for `projects` endpoint which is displayed on the
  browsable response
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    577f4ae View commit details
    Browse the repository at this point in the history

  16. Make build.state render as code/name

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    f5502ea View commit details
    Browse the repository at this point in the history

  17. Generate valid links for current logged in user in documentation

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    47888dd View commit details
    Browse the repository at this point in the history

  18. Omit form rendering on POST for builds endpoint

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    9da9ede View commit details
    Browse the repository at this point in the history

  19. Default router with nesting support

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6930902 View commit details
    Browse the repository at this point in the history

  20. Use custom AlphabeticalSortedJSONRenderer

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    a528102 View commit details
    Browse the repository at this point in the history

  21. Use JWT as default Token authentication

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e827cad View commit details
    Browse the repository at this point in the history

  22. Register users endpoint

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    36cf2d2 View commit details
    Browse the repository at this point in the history

  23. Add documentation to the root view of BrowsableAPI

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    bbeb9b7 View commit details
    Browse the repository at this point in the history

  24. Follow the pattern for URLs

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d5aed8a View commit details
    Browse the repository at this point in the history

  25. Return proper serializers (Version, Build) depending on the action

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b7055c5 View commit details
    Browse the repository at this point in the history

  26. Comment about why BrowsableAPI does not work on no GET/POST methods

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    0f2a7fc View commit details
    Browse the repository at this point in the history

  27. Make PATCH/PUT for version return properly 204 and No Content

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6a620c8 View commit details
    Browse the repository at this point in the history

  28. Make superproject endpoint to return a single project if exists

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e970e96 View commit details
    Browse the repository at this point in the history

  29. Browsable API branding

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    dfa5b2e View commit details
    Browse the repository at this point in the history

  30. Proper query for dynamic description

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    f4475a1 View commit details
    Browse the repository at this point in the history

  31. Fix superproject serializer field

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    cf905c5 View commit details
    Browse the repository at this point in the history

  32. Go back to simple Token authorization

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    c363eeb View commit details
    Browse the repository at this point in the history

  33. Use internal documentation framework

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    547ead4 View commit details
    Browse the repository at this point in the history

  34. Update Project filters and docs

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b1b38b3 View commit details
    Browse the repository at this point in the history

  35. Update docs for triggering a build

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    745558b View commit details
    Browse the repository at this point in the history

  36. Linting

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    31cc708 View commit details
    Browse the repository at this point in the history

  37. Organize API v1, v2 and v3 structure

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    254def3 View commit details
    Browse the repository at this point in the history

  38. Revert api auth URL to keep compatibility

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    0b9ab9e View commit details
    Browse the repository at this point in the history

  39. Remove autogenerated URL docs

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    7fdec50 View commit details
    Browse the repository at this point in the history

  40. Cleanup

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e014d86 View commit details
    Browse the repository at this point in the history

  41. Typo fixed

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    86c63b3 View commit details
    Browse the repository at this point in the history

  42. Do not expose names on API results

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    1e9355c View commit details
    Browse the repository at this point in the history

  43. Extend docs a little

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    39ff39c View commit details
    Browse the repository at this point in the history

  44. Use our own querysets/managers permission backend

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b4b8bab View commit details
    Browse the repository at this point in the history

  45. Rename field

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b676988 View commit details
    Browse the repository at this point in the history

  46. Typo

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    1029b2d View commit details
    Browse the repository at this point in the history

  47. Handle detail/list permissions in a Mixin

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    db51c32 View commit details
    Browse the repository at this point in the history

  48. Allow authenticated users and authenticate them only via Token

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    2249f6e View commit details
    Browse the repository at this point in the history

  49. Use proper queryset for ProjectViewSet.subprojects

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    289d927 View commit details
    Browse the repository at this point in the history

  50. Use pagination_class on APIv3 settings

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    eb3d358 View commit details
    Browse the repository at this point in the history

  51. Different approach to centralize authentication on APIAuthMixin

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    bbe4113 View commit details
    Browse the repository at this point in the history

  52. Tests showing small problems on some endpoints

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    512b5df View commit details
    Browse the repository at this point in the history

  53. Define /projects/pip/subprojects/ as a nested listing view

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    995fd09 View commit details
    Browse the repository at this point in the history

  54. Refactor and exception for /api/v3/projects/ listing

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b3736cb View commit details
    Browse the repository at this point in the history

  55. Make /projects/pip/translations/ a proper listing view (nested)

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    894ba15 View commit details
    Browse the repository at this point in the history

  56. Better query/modeling for subprojects

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    13e4d66 View commit details
    Browse the repository at this point in the history

  57. Fix subprojects query

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    9c0dda6 View commit details
    Browse the repository at this point in the history

  58. Render subproject/superproject in detail

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6abd053 View commit details
    Browse the repository at this point in the history

  59. Remove unused import

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e57843e View commit details
    Browse the repository at this point in the history

  60. Properly generation of vcs_url for Version object

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b473ddc View commit details
    Browse the repository at this point in the history

  61. Prefetch relations on Project queryset

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    df82ddd View commit details
    Browse the repository at this point in the history

  62. Serializer docstrings

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    f519787 View commit details
    Browse the repository at this point in the history

  63. Rely on a custom permission class 

    We need both things,

1. permission class to handle methods that does not pass over
`get_queryset` (POST, for example)
2. a mixin with `get_queryset` to return the proper queryset for the
logged in user
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    854530f View commit details
    Browse the repository at this point in the history

  64. Some docstrings

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4406687 View commit details
    Browse the repository at this point in the history

  65. Cleanup after rebase

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e6585e2 View commit details
    Browse the repository at this point in the history

  66. Response (list/detail) test cases

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ebbe613 View commit details
    Browse the repository at this point in the history

  67. More tests and superproject endpoint fixed

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    443f277 View commit details
    Browse the repository at this point in the history

  68. Remove old examples

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d09c09f View commit details
    Browse the repository at this point in the history

  69. Requirements updated

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    41ef2d3 View commit details
    Browse the repository at this point in the history

  70. Avoid throttling on tests

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    55cbf46 View commit details
    Browse the repository at this point in the history

  71. Variable name

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4e74205 View commit details
    Browse the repository at this point in the history

  72. Explicit return

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    86f89f0 View commit details
    Browse the repository at this point in the history

  73. Rename file

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    2035ea1 View commit details
    Browse the repository at this point in the history

  74. Remove unused import

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    8d11b9d View commit details
    Browse the repository at this point in the history

  75. Lint fixes

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    99c7954 View commit details
    Browse the repository at this point in the history

  76. pre-commit auto style

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    276a979 View commit details
    Browse the repository at this point in the history

  77. Improve/Fix build triggering

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    5dfc7bb View commit details
    Browse the repository at this point in the history

  78. Fix BrowsableAPIRenderer /projects/

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    c034972 View commit details
    Browse the repository at this point in the history

  79. Fix serializer on Build

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    fa0dc1f View commit details
    Browse the repository at this point in the history

  80. More docstrings

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e0b716a View commit details
    Browse the repository at this point in the history

  81. Valid success field on Build object

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    c4da1b7 View commit details
    Browse the repository at this point in the history

  82. Use created instead of date_joined on User response

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    e3a58e2 View commit details
    Browse the repository at this point in the history

  83. Update the APIv3 docs to the current state of the implementation

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    86d8865 View commit details
    Browse the repository at this point in the history

  84. Increase logged in throttling to 60/minute

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    2e40de9 View commit details
    Browse the repository at this point in the history

  85. Typo

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    9ae1814 View commit details
    Browse the repository at this point in the history

  86. Always expand users in Project details

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    fa5c823 View commit details
    Browse the repository at this point in the history

  87. Move specific list action on projects view to the specific view

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b634daa View commit details
    Browse the repository at this point in the history

  88. Remove /projects/pip//users/ endpoint

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4f1f587 View commit details
    Browse the repository at this point in the history

  89. Docstring URL typo

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    741e017 View commit details
    Browse the repository at this point in the history

  90. User endpoint does not exist anymore 

    No need to make this exception here.
    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ade5392 View commit details
    Browse the repository at this point in the history

  91. Remove some fields from responses

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    71a6539 View commit details
    Browse the repository at this point in the history

  92. Use more generic viewset from DRF

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6d3eee5 View commit details
    Browse the repository at this point in the history

  93. Rename mixin to match what it does (QuerySet)

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    85b393c View commit details
    Browse the repository at this point in the history

  94. Rename "links" field to "_links" since it's an internal generated field

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    b4d7942 View commit details
    Browse the repository at this point in the history

  95. Lint fixes

    @humitos
    humitos committed May 7, 2019
    Configuration menu
    Copy the full SHA
    8ebfb1c View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. Inherit order matters 

    NestedViewSetMixin has to be on the left of ProjectQuerySetMixin to
filter nested results properly.
    @humitos
    humitos committed May 8, 2019
    Configuration menu
    Copy the full SHA
    e4ac327 View commit details
    Browse the repository at this point in the history