Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to styles key from style key #1467

Closed
wants to merge 1 commit into from
Closed

Switch to styles key from style key #1467

wants to merge 1 commit into from

Conversation

polyzen
Copy link

@polyzen polyzen commented May 2, 2023

style key removed in Sphinx 7:
sphinx-doc/sphinx#11381

@polyzen polyzen requested a review from a team as a code owner May 2, 2023 22:29
benjaoming
benjaoming reviewed May 3, 2023
View reviewed changes
sphinx_rtd_theme/layout.html
Comment on lines 27 to +28
{%- if sphinx_version_info < (4, 0) -%}
<link rel="stylesheet" href="{{ pathto('_static/' + style, 1) }}" type="text/css" />
<link rel="stylesheet" href="{{ pathto('_static/' + styles[-1], 1) }}" type="text/css" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polyzen - thanks for opening this. However, the line that you are changing is only be relevant for if sphinx_version_info < (4, 0).

I think #1465 was closed because the bug was finally identified to have another origin?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brainfart.

@polyzen polyzen closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaoming benjaoming benjaoming left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polyzen @benjaoming